[GCSI-515] update fastlane build actions android/ios #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ld path and + specs
ahmedhany98
reviewed
Aug 11, 2025
lib/fastlane/plugin/instabug_stores_upload/helper/instabug_stores_upload_helper.rb
Outdated
Show resolved
Hide resolved
ahmedhany98
reviewed
Aug 11, 2025
lib/fastlane/plugin/instabug_stores_upload/actions/instabug_build_android_app_action.rb
Show resolved
Hide resolved
ahmedhany98
reviewed
Aug 13, 2025
| ] | ||
| build_keys.each do |build_key| | ||
| build_path = lane_context[build_key] | ||
| return build_path if build_path && !build_path.empty? |
There was a problem hiding this comment.
Suggested change
| return build_path if build_path && !build_path.empty? | |
| return build_path if build_path.present? |
There was a problem hiding this comment.
.present? requires active support and we don't have Rails here.
So, I will keep the current implementation.
Fix issues while testing + extract error message
ahmedhany98
reviewed
Aug 15, 2025
Comment on lines
43
to
47
| key = option.key | ||
| unless INSTABUG_KEYS.include?(key) | ||
| value = params[key] | ||
| filtered_config[key] = value if value | ||
| end |
There was a problem hiding this comment.
Suggested change
| key = option.key | |
| unless INSTABUG_KEYS.include?(key) | |
| value = params[key] | |
| filtered_config[key] = value if value | |
| end | |
| key = option.key | |
| filtered_config[key] = params[key] unless INSTABUG_KEYS.include?(key) |
I think the user can pass a key with value false which will be excluded from the if case
ahmedhany98
reviewed
Aug 15, 2025
Comment on lines
+159
to
+164
| build_keys = [ | ||
| SharedValues::GRADLE_ALL_APK_OUTPUT_PATHS, | ||
| SharedValues::GRADLE_APK_OUTPUT_PATH, | ||
| SharedValues::GRADLE_ALL_AAB_OUTPUT_PATHS, | ||
| SharedValues::GRADLE_AAB_OUTPUT_PATH | ||
| ] |
There was a problem hiding this comment.
This could return (array / string / nil).
And we should always send the build_path as an array to match the TDD.
ahmedhany98
reviewed
Aug 15, 2025
| build_time = (Time.now - build_start_time).round | ||
|
|
||
| # Extract IPA path from Fastlane environment | ||
| build_path = Actions.lane_context[SharedValues::IPA_OUTPUT_PATH] |
There was a problem hiding this comment.
This should be an array instead of string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.